starknet_patricia_storage: non mut get in storage trait#12123
starknet_patricia_storage: non mut get in storage trait#12123nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/dont-cache-readsfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
41cc5f2 to
3ebf9db
Compare
069d687 to
5e1127c
Compare
3ebf9db to
7091357
Compare
5e1127c to
76ee609
Compare
7091357 to
d58cd4a
Compare
76ee609 to
a360e7f
Compare
d58cd4a to
f899e10
Compare
a360e7f to
71c52d3
Compare
f899e10 to
df1d000
Compare
71c52d3 to
b50a0d9
Compare
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware).
8c20344 to
a2c1ea7
Compare
1ccd7ab to
2c08cc7
Compare
2c08cc7 to
fa31e81
Compare
a2c1ea7 to
d50807e
Compare
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware).
fa31e81 to
8e3541d
Compare
d50807e to
82c0e32
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 8 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware).
8e3541d to
40845b0
Compare
82c0e32 to
42bb057
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on nimrod-starkware).
40845b0 to
cd93f36
Compare
42bb057 to
8ee2dc3
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on nimrod-starkware).
cd93f36 to
7f58309
Compare
8ee2dc3 to
622151d
Compare

Note
Medium Risk
Touches a widely-used core trait and multiple storage backends, so compilation should catch most issues but any missed impl/call site could break builds or subtly change caching/thread-safety assumptions.
Overview
Updates the
starknet_patricia_storageStoragetrait so read APIs (get,mget) take&selfinstead of&mut self, and applies the signature change across all storage implementations (Aerospike, MDBX, RocksDB, map/cached, short-key wrappers, andNullStorage).Adjusts benchmark/test call sites to stop requiring mutable clones for read-only operations (e.g., CLI interference
mgettask and concurrent access test), making read paths easier to share across tasks/threads.Written by Cursor Bugbot for commit 622151d. This will update automatically on new commits. Configure here.